This repository was archived by the owner on Apr 30, 2023. It is now read-only.
LinkedIn profile URL is not displayed properly if profile URL contains emoji#27
Open
pyonghe wants to merge 3 commits intovysecurity:masterfrom
Open
LinkedIn profile URL is not displayed properly if profile URL contains emoji#27pyonghe wants to merge 3 commits intovysecurity:masterfrom
pyonghe wants to merge 3 commits intovysecurity:masterfrom
Conversation
Owner
|
People use Emoji in name...?
…On Fri, 4 Jun 2021 at 18:51, yyhh91 ***@***.***> wrote:
E.g. When you visit a profile url with emoji, the link is not displayed
properly,
[image: image]
<https://user-images.githubusercontent.com/7576046/120790593-bdb42280-c565-11eb-888a-be147e0aade2.png>
[image: image]
<https://user-images.githubusercontent.com/7576046/120790257-47afbb80-c565-11eb-881e-4bad5289e62f.png>
By encoding and the replacing the \x with % this solve the issue as shown
below,
repr(data_slug.encode("utf-8")).replace("\x","%").replace("b","",1).replace("'","")
------------------------------
You can view, comment on, or merge this pull request online at:
#27
Commit Summary
- Updated linkedin profile link not displayed correctly if there is
emoji in the URL
- Fix Url encoding when there is emoji in linkedin profile link
File Changes
- *M* .gitignore
<https://github.com/vysecurity/LinkedInt/pull/27/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(2)
- *M* LinkedInt.cfg
<https://github.com/vysecurity/LinkedInt/pull/27/files#diff-2c447caa326d6d30f54feb30e427b452bb32d23007e2bde2420a468b0b962765>
(5)
- *M* LinkedInt.py
<https://github.com/vysecurity/LinkedInt/pull/27/files#diff-5d765897f06e43579aa8ae9e225622bd2abc86f20226a679986267bcbb5f1631>
(6)
Patch Links:
- https://github.com/vysecurity/LinkedInt/pull/27.patch
- https://github.com/vysecurity/LinkedInt/pull/27.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3N7UTICCPBOPE7O2WR2ZTTRCV43ANCNFSM46CSCHJA>
.
|
Author
|
Yes there are instances where LinkedIn profile url has emoji. As shown in the screen cap above. Then the generated html will have a wrong url due to the encoding that is done with that emoji. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. When you visit a profile url with emoji, the link is not displayed properly,
By encoding and the replacing the \x with % this solve the issue as shown below,
repr(data_slug.encode("utf-8")).replace("\x","%").replace("b","",1).replace("'","")